Skip to content

Simplify and unify UNIX timezone retrival - #938

Open
Secrus wants to merge 1 commit into
python-pendulum:masterfrom
Secrus:unix-timezone
Open

Simplify and unify UNIX timezone retrival#938
Secrus wants to merge 1 commit into
python-pendulum:masterfrom
Secrus:unix-timezone

Conversation

@Secrus

@Secrus Secrus commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Closes: #837
Closes: #840
Closes: #829

@Secrus
Secrus requested a review from ashb January 30, 2026 14:29
@codspeed

codspeed Bot commented Jan 30, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing Secrus:unix-timezone (150aa01) with master (aea611d)

Summary

✅ 1 untouched benchmark

@Secrus

Secrus commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator Author

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

@mgorny

mgorny commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

@mgorny since this changes how things work for Gentoo, could you check/confirm that /etc/localtime works on Gentoo?

If you're asking whether tests pass after this change on my system, they do. They also pass if I remove /etc/localtime altogether or copy the specific timezone there. I think that's all the scenarios we "support".

PS if you know any other distro maintainers, please notify/ping them, I would love to get broader info on this matter

CC @hroncok (sorry, don't recall anyone else offhand, though I really should have)

ashb
ashb approved these changes Sep 22, 2026
View reviewed changes

@ashb ashb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sensible, but I can't quite tell if this will result in different TZ determination on some systems?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb ashb approved these changes

Assignees

No one assigned

Labels

timezones

Projects

None yet

Milestone

No milestone

3 participants

@Secrus @mgorny @ashb